Upgrade to Cairo 2.5.3 and other refactors
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure
El El jue, 1 feb 2024 a la(s) 8:52, Lucas @ StarkWare <
***@***.***> escribió:
… put #272 <#272>
and #270 <#270>
in the same PR as this one
—
Reply to this email directly, view it on GitHub
<#271 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIKSPDJKST4HODF4YTVKK3YROT3JAVCNFSM6AAAAABCTP4XPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGUYTINBSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
delaaxe
force-pushed
the
feat/cairo-2.5.0
branch
from
f625f61 to
1898a08
Compare
|
@LucasLvy done |
delaaxe
changed the title
2.5.0 and other refactors2.5.3 and other refactors
0xLucqs
requested changes
Feb 2, 2024
Revert changes
delaaxe
force-pushed
the
feat/cairo-2.5.0
branch
from
bbedc21 to
e49bda0
Compare
I would wait for snfoundry to be ready before doing it in library code because error message catching infra isn't fully implemented yet foundry-rs/starknet-foundry#1627 |
delaaxe
force-pushed
the
feat/cairo-2.5.0
branch
from
65d5ede to
26e9b19
Compare
delaaxe
force-pushed
the
feat/cairo-2.5.0
branch
from
26e9b19 to
7ee011b
Compare
|
done as much as i could, it failed in many places (out of gas, formatter unimplemented, other weird errors) |
|
Let's not care about other tools, if someone wants to use it with foundry they'll use the old version |
|
well we at argent would like to use the latest alexandria with foundry, but the assert! macros feel a bit too unstable to be shipped to mainnet |
0xLucqs
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information